Skip to content

Manchester | 26-ITP-Sep | khalid bih | Sprint 1 | Wireframe#997

Open
khalidbih wants to merge 7 commits intoCodeYourFuture:mainfrom
khalidbih:wireframe
Open

Manchester | 26-ITP-Sep | khalid bih | Sprint 1 | Wireframe#997
khalidbih wants to merge 7 commits intoCodeYourFuture:mainfrom
khalidbih:wireframe

Conversation

@khalidbih
Copy link

@khalidbih khalidbih commented Jan 20, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I created the Wireframe project page with three articles explaining README, Wireframe, and Git branches. Footer is fixed, and CSS is linked.

@khalidbih khalidbih added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 20, 2026
@netlify
Copy link

netlify bot commented Jan 20, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 77d2f46
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/697fea7c11d4f30008a4aef3
😎 Deploy Preview https://deploy-preview-997--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@jenny-alexander jenny-alexander self-requested a review January 26, 2026 23:53
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 26, 2026
jenny-alexander
jenny-alexander reviewed Jan 27, 2026
View reviewed changes
Copy link
Contributor

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @khalidbih - nice job getting your PR created with your exercise submission! Your wireframe webpage looks very good. I see a few places to improve upon.

  • Can you run your webpage through https://validator.w3.org/? I see an error that should be fixed.
  • Can you please replace the placeholder.svg image with an image that is related to the article?
  • Can you review the footer styling? Currently is overlapping on the 'Read more' buttons and cutting them off a little bit.
Screenshot 2026-01-26 at 9 31 47 PM

@khalidbih
Copy link
Author

khalidbih commented Jan 27, 2026

Hi @khalidbih - nice job getting your PR created with your exercise submission! Your wireframe webpage looks very good. I see a few places to improve upon.

  • Can you run your webpage through https://validator.w3.org/? I see an error that should be fixed.
  • Can you please replace the placeholder.svg image with an image that is related to the article?
  • Can you review the footer styling? Currently is overlapping on the 'Read more' buttons and cutting them off a little bit.
Screenshot 2026-01-26 at 9 31 47 PM

Thank you for reviewing my PR. I will make improvements to my wireframe coursework following the feedback you provided.

@khalidbih khalidbih added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 30, 2026
@jenny-alexander
Copy link
Contributor

jenny-alexander commented Jan 30, 2026

@khalidbih Your wireframe exercise webpage has significant improvements! 👍

Can you please review the following:

  • The footer should be fixed to the bottom of the page. This means that I should see the footer at all times. You might find this resource helpful: https://www.w3schools.com/howto/howto_css_fixed_footer.asp
  • You may added the placeholder.svg and wireframe.png files to the /images directory. Please review. Since the files already exist within the /Wireframe directory, there is no need to replicate them again!

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 30, 2026
@khalidbih khalidbih added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 31, 2026
@khalidbih
Copy link
Author

khalidbih commented Jan 31, 2026

@khalidbih Your wireframe exercise webpage has significant improvements! 👍

Can you please review the following:

  • The footer should be fixed to the bottom of the page. This means that I should see the footer at all times. You might find this resource helpful: https://www.w3schools.com/howto/howto_css_fixed_footer.asp
  • You may added the placeholder.svg and wireframe.png files to the /images directory. Please review. Since the files already exist within the /Wireframe directory, there is no need to replicate them again!

The footer is now fixed at the bottom and stays visible at all times. I’ve also removed duplicate images—placeholder.svg and wireframe.png remain only in the /Wireframe directory. Thank you for the helpful resource.

@khalidbih khalidbih changed the title Manchester | 26-ITP-Sep | khalid bih | Sprint 1 | Wireframe Manchester | 26-ITP-Sep | khalid bih | Sprint 1 | Wireframe Jan 31, 2026
@khalidbih khalidbih added Module-Onboarding The name of the module. and removed Module-Onboarding The name of the module. labels Jan 31, 2026
@khalidbih
Copy link
Author

khalidbih commented Jan 31, 2026

The code in this PR is complete and working. The failing workflow is due to the validator trying to parse issue #1099, which is not mine. All changes meet the requirements, and the footer and images are fixed as requested.

@jenny-alexander
Copy link
Contributor

jenny-alexander commented Jan 31, 2026

The code in this PR is complete and working. The failing workflow is due to the validator trying to parse issue #1099, which is not mine. All changes meet the requirements, and the footer and images are fixed as requested.

@khalidbih Oops! Can you check your index.html file? I believe you deleted the images directory and all of the images within it.

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 31, 2026
@khalidbih khalidbih added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 2, 2026
@khalidbih
Copy link
Author

khalidbih commented Feb 2, 2026

The code in this PR is complete and working. The failing workflow is due to the validator trying to parse issue #1099, which is not mine. All changes meet the requirements, and the footer and images are fixed as requested.

@khalidbih Oops! Can you check your index.html file? I believe you deleted the images directory and all of the images within it.

Thank you for pointing this out. The images folder hadn’t been pushed. I’ve now added and committed the images directory.

@jenny-alexander
Copy link
Contributor

jenny-alexander commented Feb 2, 2026

@khalidbih Nice work on this PR 🙂

@jenny-alexander jenny-alexander added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 2, 2026
@khalidbih
Copy link
Author

khalidbih commented Feb 2, 2026

@khalidbih Nice work on this PR 🙂

Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jenny-alexander jenny-alexander jenny-alexander left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khalidbih @jenny-alexander